Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appmesh: added support for hostname based routing and path/hostname rewrite #25819

Merged
merged 6 commits into from
Jul 15, 2022
Merged

appmesh: added support for hostname based routing and path/hostname rewrite #25819

merged 6 commits into from
Jul 15, 2022

Conversation

julada
Copy link
Contributor

@julada julada commented Jul 14, 2022 •
edited
Loading

  • added support for hostname based routing in an appmesh gateway route
  • added support for rewrite settings in appmesh gateway route

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23041
Closes #20272

Output from acceptance testing:

$ make testacc TESTS=TestAccAppMesh_serial/GatewayRoute PKG=appmesh

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run='TestAccAppMesh_serial/GatewayRoute'  -timeout 180m
=== RUN   TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/GatewayRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/basic
=== RUN   TestAccAppMesh_serial/GatewayRoute/disappears
=== RUN   TestAccAppMesh_serial/GatewayRoute/grpcRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/httpRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/http2Route
=== RUN   TestAccAppMesh_serial/GatewayRoute/tags
--- PASS: TestAccAppMesh_serial (129.22s)
    --- PASS: TestAccAppMesh_serial/GatewayRoute (129.21s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/basic (13.11s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (10.39s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (20.94s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (27.29s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/http2Route (28.61s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/tags (28.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appmesh    131.433s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 14, 2022
github-actions[bot]
github-actions bot reviewed Jul 14, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @julada 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@julada julada force-pushed the feature/appmesh/support-hostname-based-routing branch from 2591fc5 to fe54eee Compare July 14, 2022 18:43
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jul 14, 2022
@julada julada changed the title appmesh: added support for hostname based routing appmesh: added support for hostname based routing and path/hostname rewrite Jul 14, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 15, 2022
@julada julada requested a review from ewbankkit as a code owner July 15, 2022 18:34
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Jul 15, 2022
ewbankkit
ewbankkit approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAppMesh_serial/GatewayRoute PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run='TestAccAppMesh_serial/GatewayRoute'  -timeout 180m
=== RUN   TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/GatewayRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/grpcRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/httpRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/http2Route
=== RUN   TestAccAppMesh_serial/GatewayRoute/tags
=== RUN   TestAccAppMesh_serial/GatewayRoute/basic
=== RUN   TestAccAppMesh_serial/GatewayRoute/disappears
--- PASS: TestAccAppMesh_serial (229.27s)
    --- PASS: TestAccAppMesh_serial/GatewayRoute (229.27s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (33.82s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (57.47s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/http2Route (55.99s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/tags (47.39s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/basic (19.45s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (15.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	233.868s

@ewbankkit
Copy link
Contributor

@julada Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e47b0a9 into hashicorp:main Jul 15, 2022
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 15, 2022
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@julada julada mentioned this pull request Jul 27, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/appmesh Issues and PRs that pertain to the appmesh service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.23.0
2 participants
@julada @ewbankkit